Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly verify webhook signature #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

michaelbeaumont
Copy link

Closes #6

Verified

This commit was signed with the committer’s verified signature.
michaelbeaumont Mike Beaumont

Verified

This commit was signed with the committer’s verified signature.
michaelbeaumont Mike Beaumont
@codecov-io
Copy link

Codecov Report

Merging #10 into master will decrease coverage by 1.9%.
The diff coverage is 95.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage   89.65%   87.75%   -1.91%     
==========================================
  Files           3        3              
  Lines          29       49      +20     
  Branches        8       12       +4     
==========================================
+ Hits           26       43      +17     
- Misses          3        6       +3
Impacted Files Coverage Δ
index.js 86.95% <95.65%> (-1.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e06dd77...7c669f4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does this actually validate webhook signatures
2 participants